Fix: ScrollBar staying in the middle of the modal (iOS) #3709
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timszot
approved these changes
Jun 22, 2021
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
This was referenced Jun 22, 2021
|
🚀 Deployed to staging in version: 1.0.73-4🚀
|
|
🚀 Deployed to production in version: 1.0.74-0🚀
|
This was referenced Oct 14, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details
There's an open issue in react native (facebook/react-native#26610) that causes the ScrollBar to be incorrectly positioned in some iOS versions. The recommended workaround involves wrapping the view in a
SafeAreaView. This PR wraps our Modal component for iOS in aSafeAreaView.No code that is run on other platforms is changed.
Fixed Issues
Fixes #3637
Tests
QA Steps
Tested On
Screenshots
Web
Mobile Web
Desktop
iOS
Simulator.Screen.Recording.-.iPhone.SE.13.7.-.2021-06-21.at.15.25.03.mp4
Android